Fix ubi_reader dependency #648
Closed
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbs-jacob
reviewed
Jun 22, 2023
| @@ -115,7 +115,7 @@ function install_cramfstools | |||
|
|
|||
| function install_ubireader | |||
| { | |||
| git clone --quiet --depth 1 --branch "master" https://github.com/jrspruitt/ubi_reader | |||
| git clone --quiet --depth 1 -b v0.8.5-master https://github.com/jrspruitt/ubi_reader | |||
There was a problem hiding this comment.
Similarly, we could achieve the same effect (without pinning to an outdated tag) by just switching main to master. Either way, I support this change to un-break the deps.sh script!
Suggested change
| git clone --quiet --depth 1 -b v0.8.5-master https://github.com/jrspruitt/ubi_reader | |
| git clone --quiet --depth 1 --branch "main" https://github.com/jrspruitt/ubi_reader |
There was a problem hiding this comment.
This isn't enough anymore, since newer version of ubi_reader use Poetry instead of setuptools (there's no setup.py).
I think the correct solution here is to edit deps.sh to install ubi_reader from PyPi instead of source (i.e. run pip install ubi_reader).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ubi_reader's repository there is no "master" branch anymore. Furthermore, the "main" branch does not use python setup.py anymore. Fixed by cloning the latest version having the setup.py install